Conversation
Root LICENSE and every crate's Cargo.toml license field move from MIT to Apache-2.0, plus the PKGBUILD license field. Adds NOTICE attribution for vendored code: lean-ctx's embedding pipeline (Apache-2.0), and the caveman/ponytail-derived flare-output/flare-code crates (MIT). cargo metadata confirms all 11 crates report license=Apache-2.0; cargo deny check licenses passes (Apache-2.0 already allow-listed in deny.toml). The paid multi-machine collaboration service stays in a separate, closed-source repo outside this project -- unaffected by this change.
📝 WalkthroughWalkthroughThe project-wide license changed from MIT to Apache-2.0. The root license text, third-party notices, Cargo manifests, and Arch package metadata were updated accordingly. ChangesLicensing update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@aur/agentflare/PKGBUILD`:
- Line 8: Update the PKGBUILD package() function to install the tracked NOTICE
file alongside LICENSE, ensuring both upstream attribution files are included in
the Arch package.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3c34c6c6-73be-4293-ba16-f4a069521285
📒 Files selected for processing (14)
Cargo.tomlLICENSENOTICEaur/agentflare/PKGBUILDcrates/agent-registry/Cargo.tomlcrates/agentflare-artifacts/Cargo.tomlcrates/agentflare-backend/Cargo.tomlcrates/agentflare-db-kit/Cargo.tomlcrates/agentflare-store/Cargo.tomlcrates/flare-code/Cargo.tomlcrates/flare-output/Cargo.tomlcrates/flare-search-kit/Cargo.tomlcrates/gateway-registry/Cargo.tomlcrates/skill-registry/Cargo.toml
| arch=('x86_64' 'aarch64') | ||
| url="https://github.com/getappz/agentflare" | ||
| license=('MIT') | ||
| license=('Apache-2.0') |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== PKGBUILD ==\n'
nl -ba aur/agentflare/PKGBUILD | sed -n '1,120p'
printf '\n== FILES ==\n'
git ls-files aur/agentflare | sed 's#^`#-` #'
printf '\n== PPA workflow snippet ==\n'
nl -ba .github/workflows/ppa-publish.yml | sed -n '1,220p'Repository: getappz/agentflare
Length of output: 212
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== PKGBUILD ==\n'
cat -n aur/agentflare/PKGBUILD | sed -n '1,140p'
printf '\n== agentflare tracked files ==\n'
git ls-files aur/agentflare | sed 's#^`#-` #'
printf '\n== NOTICE references in aur/agentflare ==\n'
grep -RIn --exclude-dir=.git --exclude='*.png' --exclude='*.jpg' --exclude='*.jpeg' --exclude='*.gif' --exclude='*.svg' 'NOTICE\|notice' aur/agentflare || true
printf '\n== PPA workflow snippet ==\n'
cat -n .github/workflows/ppa-publish.yml | sed -n '1,260p'Repository: getappz/agentflare
Length of output: 11095
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== tracked NOTICE-like files in repo ==\n'
git ls-files | grep -E '(^|/)(NOTICE|NOTICE\.txt|NOTICE\.md|notice)(\..*)?$' || true
printf '\n== all NOTICE references in repo ==\n'
grep -RIn --exclude-dir=.git 'NOTICE' . || true
printf '\n== root files ==\n'
git ls-files | sed -n '1,220p'Repository: getappz/agentflare
Length of output: 8030
Install NOTICE in the Arch package.
package() installs LICENSE but omits the tracked NOTICE file, so the Arch artifact drops the upstream attribution notices. Add:
Proposed fix
install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
+ install -Dm644 NOTICE "$pkgdir/usr/share/licenses/$pkgname/NOTICE"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aur/agentflare/PKGBUILD` at line 8, Update the PKGBUILD package() function to
install the tracked NOTICE file alongside LICENSE, ensuring both upstream
attribution files are included in the Arch package.
Summary
LICENSEand every crate'sCargo.tomllicensefield move from MIT to Apache-2.0, plusaur/agentflare/PKGBUILD.NOTICEattribution for vendored code: lean-ctx's embedding pipeline (Apache-2.0,crates/agentflare-store/src/embed.rs+embedding_pipeline/), and the caveman/ponytail-derivedflare-output/flare-codecrates (MIT).2026-07-17-agentflare-store-v1spec's Licensing section but explicitly scoped out of that crate's own implementation plan as a separate action item.Why
agentflare-store(both projects now share one license).lean-ctxproject, which is already Apache-2.0.Test plan
cargo metadata --no-depsconfirms all 11 crates reportlicense=Apache-2.0cargo deny check licensespasses (Apache-2.0 already allow-listed indeny.toml, confirmed no CI risk)git remote(JuliusBrussee/caveman, DietrichGebert/ponytail, yvgude/lean-ctx)cargo test --workspace/clippy — no.rsfiles touched, change is license metadata + text files onlySummary by CodeRabbit