refactor: consolidate agent-config path + JSON read/write helpers

[devin-ai-integration]

Summary

The agent-config code (init.rs, components.rs, uninstall.rs) had repeated the same three inline idioms all over the place. This PR extracts them into shared helpers and routes the call sites through them — no behavior change other than reads becoming JSONC-tolerant (see below).

1. Config path construction — home().join(".claude").join("settings.json"), ~/.claude.json, ~/.claude/rules, and the ~/.config/opencode/{opencode.jsonc,rules} triple were hand-built at ~30 sites. New helpers in paths.rs:

claude_dir() / claude_settings_path() / claude_rules_dir() / claude_json_path()
opencode_dir() / opencode_config_path() / opencode_rules_dir()

2. Read-config-as-object — every wire_*/merge_* did:

let mut v: Value = fs::read_to_string(&p).ok()
    .and_then(|s| serde_json::from_str(&s).ok())
    .unwrap_or_else(|| json!({}));
if !v.is_object() { v = json!({}); }

Collapsed to jsonc::read_json_object(&p, || json!({})), which reads, falls back to default() on missing/unreadable/invalid/non-object, and guarantees an object.

3. Write-pretty-JSON-config — fs::write(&p, serde_json::to_string_pretty(&v).unwrap() + "\n") (8+ copies, mixed unwrap() / unwrap_or_default()) → jsonc::write_json_pretty(&p, &v), keeping the exact 2-space-indent + trailing-\n byte format in one place.

Net: -142 / +156 lines, but the +156 is mostly the four new documented helpers and their tests; the duplicated call sites shrink substantially.

Test plan

• cargo test (581 unit tests pass; new jsonc helper tests added. The caveman_cli integration test is flaky under compile load on both master and this branch — broken pipe writing to a stubbed CLI's stdin — unrelated to this change.)
• cargo clippy --locked --workspace --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic
• cargo fmt --check

Notes for reviewers

• Risk areas / edge cases: read_json_object reads via the existing read_jsonc, so ~/.claude/settings.json, ~/.codex/hooks.json, and .cursor/hooks.json reads now tolerate JSONC (comments / trailing commas) instead of silently falling back to an empty object on serde_json::from_str failure. JSONC is a strict superset of JSON (see pure_json_passthrough test), so any previously-parsing input parses identically; this only adds tolerance and is aligned with the reason jsonc.rs exists (avoid clobbering a user's comment-bearing config).
• Backwards compatibility: on-disk output format is unchanged (pretty JSON + trailing newline). merge_json/merge_opencode_mcp signatures changed from &PathBuf to &Path (satisfies clippy::ptr_arg; callers coerce automatically).

Link to Devin session: https://app.devin.ai/sessions/19a419ad0c9e458e8fcfeef00b82d066
Requested by: @getappz

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability when reading and updating Claude Code and OpenCode configuration files.
  • Preserved support for JSONC files containing comments and trailing commas.
  • Standardized configuration and rules locations to reduce path-related issues.
  • Improved cleanup when removing integrations and related configuration entries.

• Refactor

  • Centralized configuration file handling for more consistent behavior across setup, synchronization, and removal workflows.

• Tests

  • Added coverage for JSONC parsing, fallback behavior, and formatted configuration output.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR centralizes Claude and OpenCode configuration paths and JSONC object handling. Component, initialization, and uninstall flows now use shared readers and pretty writers, with tests covering fallback behavior, JSONC parsing, and newline-terminated output.

Changes

Configuration persistence standardization

Layer / File(s)	Summary
Shared JSONC and path helpers src/jsonc.rs, src/paths.rs	Adds object-validating JSONC reads, pretty JSON writes, and derived Claude/OpenCode paths with test coverage.
Component configuration updates src/components.rs	Updates component checks, merges, rule targets, skill synchronization, and mode writes to use centralized paths and JSON helpers.
Initialization and hook wiring src/init.rs	Standardizes configuration loading and persistence across Claude, Cursor, Codex, and OpenCode wiring flows.
Configuration cleanup src/uninstall.rs	Uses centralized paths and shared JSON writing for Claude, OpenCode, and MCP cleanup.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• getappz/agentflare#105: Touches the same component wiring and persistence flows.
• getappz/agentflare#157: Modifies related hook wiring and Claude/OpenCode merge logic.
• getappz/agentflare#188: Refactors the same JSONC helper usage in component and initialization code.

Suggested reviewers: getappz

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: consolidating agent-config path handling and JSON read/write helpers.
Description check	✅ Passed	The description matches the template well, with a clear summary, completed test plan, and reviewer notes on risks and compatibility.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch devin/1784314856-dedup-config-json-utils

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/uninstall.rs`:
- Around line 105-111: Update clean_opencode to replace the serde_json::from_str
read of opencode_config_path() with the shared JSONC-aware object reader.
Preserve the existing cleanup behavior while allowing comments and trailing
commas in opencode.jsonc so instructions are removed successfully.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e07467c-9665-4cd5-986c-330d12bbac87

📥 Commits

Reviewing files that changed from the base of the PR and between a9d3095 and 1c13651.

📒 Files selected for processing (5)

• src/components.rs
• src/init.rs
• src/jsonc.rs
• src/paths.rs
• src/uninstall.rs

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use the JSONC-aware reader for OpenCode cleanup.

opencode_config_path() targets opencode.jsonc, but the subsequent read still uses serde_json::from_str (Lines 113–117). Any valid config containing comments or trailing commas will fail parsing, so uninstall silently leaves its instructions behind. Replace this read with the shared JSONC object reader.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/uninstall.rs` around lines 105 - 111, Update clean_opencode to replace
the serde_json::from_str read of opencode_config_path() with the shared
JSONC-aware object reader. Preserve the existing cleanup behavior while allowing
comments and trailing commas in opencode.jsonc so instructions are removed
successfully.