Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: unlock screen (WIP) #243

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Feat: unlock screen (WIP) #243

merged 8 commits into from
Feb 1, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 30, 2024

TODO

  • review storing the encryption key for checking in the http service
  • is it ok that we only support the http usecase for now? - I think we can rely on standard PC unlock screen for Wails.
  • review cookie structure
  • return to previous URL functionality after logging in
  • proper password check on startup
  • setup page can currently be accessed if the app is running without a password - a malicious user could then change the node backend. I think this should be locked if the app is running
  • prevent brute forcing passwords - currently rate limited at 1 request per second
  • review general UX (start/unlock flow)

@rolznz rolznz marked this pull request as ready for review January 31, 2024 07:09
http_service.go Outdated Show resolved Hide resolved
@rolznz rolznz merged commit 34cbd94 into feat/wails-v2 Feb 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant