Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

chore: push card footer to bottom #562

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

im-adithya
Copy link
Member

Note

mb-5 is just added to keep the sats in other cards in the same line as Savings Balance sats, if this feels hacky, we can group Header and Content in a div and add flex flex-col justify-between to the <Card>

Before

Screenshot 2024-07-03 at 10 40 02 AM

After

Screenshot 2024-07-03 at 10 39 44 AM

@rolznz
Copy link
Collaborator

rolznz commented Jul 3, 2024

justify-between seems better to me rather than random margins!

@im-adithya
Copy link
Member Author

Done!

Copy link
Collaborator

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron
Copy link

This adds quite a bit of markup 🤔 Couldn't you just add flex flex-col to the card and apply flex-grow to the CardContent element? That should work without additional markup...

@im-adithya
Copy link
Member Author

Thanks Flexbox Supreme 🫡

Screenshot 2024-07-03 at 12 26 40 PM

@reneaaron reneaaron merged commit f82bd5f into master Jul 4, 2024
8 checks passed
@reneaaron reneaaron deleted the task-liquidity-cards branch July 4, 2024 09:38
reneaaron pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants