[Freepilot] feat: warn kind 3 insufficient ptags #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add warning logic to signEventOrPrompt for kind 3 events with insufficient p-tags - Display prominent warning banner in confirmation UI for these events - Always show confirmation prompt even when permissions are granted - Add translation strings for the warning message - Include comprehensive tests for the new functionality This helps prevent users from accidentally overwriting their entire follow lists when signing into new Nostr clients, which is a pervasive issue in the ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177
commit 4756a85
Author: freepilot-bot [email protected]
Date: Mon Jun 16 10:11:19 2025 +0000
View job on Freepilot: https://freepilot.albylabs.com/jobs/10