Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon & copy for adding new wallets #3253

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Some users seem not to be aware of the multi-account capabilities.

  • Replaces circled plus icon with just the plus icon for for better recognizability
  • Replaced "Connect a Wallet" with just "Add"

image

@jpl-btc
Copy link
Contributor

jpl-btc commented Oct 16, 2024

Just a reminder for why doing this:

  • we have seen people on social media asking how to make more than account
  • we received jotforms of people uninstalling because they thought they could not have more than one profile
  • I had to send emails explaining how to manage multiple extension accounts due to users not understanding how to do it by themselves by exploring the extension interface

@bumi
Copy link
Collaborator

bumi commented Oct 16, 2024

+1 what do we do with the translations?

@reneaaron
Copy link
Contributor Author

I removed existing translations and fixed a test.

@reneaaron reneaaron marked this pull request as ready for review October 16, 2024 18:51
@pavanjoshi914
Copy link
Contributor

tACk. thanks for updating other translation files as well!

@pavanjoshi914 pavanjoshi914 merged commit f36dc49 into master Oct 17, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the fix/add-account branch October 17, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants