Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tailwindcss-3d plugin breaks scale animations #3211

Merged

Conversation

dylancom
Copy link
Contributor

@dylancom dylancom commented Jul 25, 2024

Describe the changes you have made in this PR

The menu's (such as UserMenu / AccountMenu) now feel "laggy" as there is no animation on the scaling. It jumps weirdly. I found out that tailwindcss-3d adjusts many classes and breaks the "scaling" transitions.

fix: remove the tailwindcss-3d plugin and create a custom plugin that provides the class that was actually used from the plugin: translate-z-0.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Copy link

socket-security bot commented Jul 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 8.3 kB types
npm/@types/[email protected] None 0 6.14 kB types
npm/@types/[email protected] None 0 7 kB types
npm/@types/[email protected] None 0 5.05 kB types
npm/[email protected] None 0 16.8 kB dougwilson
npm/[email protected] None 0 19.1 kB dougwilson
npm/[email protected] None 0 10.2 kB dougwilson
npm/[email protected] None 0 4.45 kB sindresorhus
npm/[email protected] None 0 5.88 kB dougwilson
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None 0 9.16 kB trysound
npm/[email protected] environment, filesystem 0 3.76 kB sindresorhus
npm/[email protected] None 0 67.9 kB jdalton
npm/[email protected] environment, filesystem 0 51.7 kB broofa
npm/[email protected] None 0 27.4 kB dougwilson
npm/[email protected] None 0 10.3 kB dougwilson
npm/[email protected] None 0 15.4 kB dougwilson
npm/[email protected] None 0 8.46 kB dougwilson
npm/[email protected] None 0 18.9 kB tim-kos
npm/[email protected] None 0 4.03 kB wesleytodd
npm/[email protected] None 0 4.68 kB dougwilson
npm/[email protected] None 0 18.5 kB dougwilson

🚮 Removed packages: npm/@swc/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@dylancom dylancom force-pushed the bugfix/broken-menu-animations branch from 9be338b to efc52d5 Compare July 25, 2024 16:04
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylancom Great catch, thanks for the PR!

tACK

cc @pavanjoshi914

@pavanjoshi914
Copy link
Contributor

Thanks for the PR! tAck

@pavanjoshi914 pavanjoshi914 merged commit 45da314 into getAlby:master Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants