Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account menu makeover when account name is larger #3173

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

pavanjoshi914
Copy link
Contributor

before:

image

after:
image

@pavanjoshi914 pavanjoshi914 requested a review from reneaaron June 14, 2024 06:15
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@@ -103,7 +103,7 @@ function AccountMenu({ showOptions = true }: Props) {
url={authAccount.avatarUrl}
/>
</div>
<div className="flex flex-col">
<div className="flex flex-col max-w-40">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this dynamic so the text field just uses the maximum available space (but gets truncated when overflowing)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Copy link
Contributor Author

@pavanjoshi914 pavanjoshi914 Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@pavanjoshi914 pavanjoshi914 merged commit 5b0b35e into master Jun 17, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the fix-makeover branch June 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants