Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nostr signing improvements #2970

Merged
merged 7 commits into from
Jan 8, 2024
Merged

feat: nostr signing improvements #2970

merged 7 commits into from
Jan 8, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

Link this PR to an issue [optional]

Fixes #2942

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914 pavanjoshi914 requested a review from rolznz January 8, 2024 10:13
rolznz
rolznz approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@pavanjoshi914 pavanjoshi914 merged commit 6aef498 into master Jan 8, 2024
5 of 6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the nostr-signing branch January 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron requested changes

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve nostr signing
3 participants
@pavanjoshi914 @rolznz @reneaaron