Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive header, navigation and headings and avatars #2959

Merged
merged 5 commits into from
Jan 31, 2024
Merged

feat: responsive header, navigation and headings and avatars #2959

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4213f8
feat: add margins around navigation icons
pavanjoshi914 Dec 22, 2023
2b12b19
feat: responsive headings in hader
pavanjoshi914 Dec 27, 2023
461c195
Merge branch 'master' into fix/header
reneaaron Jan 30, 2024
2606b9b
chore: change class placements
pavanjoshi914 Jan 31, 2024
71514b0
Merge branch 'fix/header' of https://github.com/getAlby/lightning-bro…
pavanjoshi914 Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/components/AccountDetailLayout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ function AccountDetailLayout() {
{account.name}
</h2>
<span>/</span>
<span>{t("title1")}</span>
<span className="text-ellipsis whitespace-nowrap overflow-hidden">
{t("title1")}
</span>
</div>
)}
</Header>
Expand Down
3 changes: 2 additions & 1 deletion src/app/components/Avatar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const AvatarImage = (props: Props) => {
style={{
width: `${props.size}px`,
height: `${props.size}px`,
flexShrink: 0,
pavanjoshi914 marked this conversation as resolved.
Show resolved Hide resolved
}}
>
<img
Expand All @@ -52,7 +53,7 @@ const AvatarSVG = (props: Omit<Props, "url">) => {
return (
<svg
className={classNames(
"rounded-full overflow-hidden translate-z-0",
"rounded-full overflow-hidden translate-z-0 flex-shrink-0",
pavanjoshi914 marked this conversation as resolved.
Show resolved Hide resolved
props.className ?? ""
)}
ref={svgRef}
Expand Down
8 changes: 5 additions & 3 deletions src/app/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ function Header({ children, headerLeft, headerRight }: Props) {
return (
<div className="bg-white py-[6px] border-b border-gray-200 dark:bg-surface-01dp dark:border-neutral-700">
<div className="flex justify-between items-center container max-w-screen-lg px-4 mx-auto">
<div className="w-8 h-8">{headerLeft}</div>
<h1 className="text-lg font-medium dark:text-white">{children}</h1>
<div className="w-8 h-8">{headerRight}</div>
<div className="w-8 h-8 mr-3">{headerLeft}</div>
<h1 className="text-lg font-medium dark:text-white overflow-hidden">
{children}
</h1>
<div className="w-8 h-8 ml-3">{headerRight}</div>
</div>
</div>
);
Expand Down
Loading