fix: return preimage for ln settlement in galoy connector #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openoms
changed the title
openoms
force-pushed
the
fix/-return-the-preimage-for-galoy-connector
branch
from
935895c to
e38bc47
Compare
reneaaron
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the galoy connector to return the preimage when the payment settles over lightning.
Intraledger settlements are not yet returning a preimage until GaloyMoney/blink#3735 is solved.
Link this PR to an issue
discussed in: #2946
Type of change
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes
How has this been tested?
manually loading to Firefox
Checklist