-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle auth flow natively #2869
Conversation
everything else is done only this is to create client. which requires a redirect url. not sure what to use as redirect url. new page in getalby.com? |
Is there a way we can append the amount of accounts the user has to the URL? |
not sure about this. why we need that? |
There are those reports that people struggling with adding another account when they are logged in because we don't prompt them. |
we build auth url and add search-params in the following way in js-sdk
I don't think we have any option to pass additional metadata such as a number of accounts. maybe we introduce such fields in options? or any separate field? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Created a follow-up-issue for improving the account connection in multi-account scenarios:
Describe the changes you have made in this PR
one way we can eliminate identity api is to use completely native browser api so that we can support all the browsers including firefox for android
doesn't require any hacks or content script. just using tabs api and event listeners which works on all the browsers including android