Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update yt battery to support new @ #1808

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: update yt battery to support new @ #1808

merged 1 commit into from
Dec 2, 2022

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Adds support for new @ in yt

Link this PR to an issue [optional]

Fixes #1790

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Screenshot 2022-12-01 at 5 18 51 PM

Screenshot 2022-12-01 at 5 18 23 PM

Screenshot 2022-12-01 at 5 18 07 PM

Screenshot 2022-12-01 at 5 17 36 PM

Screenshot 2022-12-01 at 5 17 23 PM

How has this been tested?

Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron
Copy link
Contributor

Let's include that into the release and come up with a plan on how we want to reliably detect tipping information on an SPA.

LGTM 🚀

@bumi bumi merged commit 6181142 into master Dec 2, 2022
@bumi bumi deleted the task-youtube branch December 2, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tipping possible when visiting a YouTube channel with new handles
3 participants