-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused runcitadel sdk #1721
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by:
Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name) Don't forget: keep earning sats! |
jest.config.js
Outdated
@@ -28,7 +28,7 @@ module.exports = { | |||
], | |||
"^.+\\.(t|j)sx?$": ["@swc/jest", swcConfig], | |||
}, | |||
transformIgnorePatterns: ["node_modules/(?!(@runcitadel))/"], | |||
transformIgnorePatterns: ["node_modules/(?!(dexie))/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was dexie added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Jest is failing: https://github.com/getAlby/lightning-browser-extension/pull/747/files#r842242790 [same reason but dexie ig]
Not exactly sure why.
@escapedcat knows: #1314 (comment)
Unit-test setup
Looks like some unit-tests fail after an update to 16/18.
This helps partly:
- Updating runcitadel Upgrade @runcitadel/sdk: 0.3.8 → 0.5.3 (major) #1280
transformIgnorePatterns: ["node_modules/(?!(dexie))/"],
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From jest:
Jest encountered an unexpected token
Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.
Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.
By default "node_modules" folder is ignored by transformers.
Here's what you can do:
• If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
• If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
• To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
• If you need a custom transformation specify a "transform" option in your config.
• If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.
You'll find more details and examples of these config options in the docs:
https://jestjs.io/docs/configuration
For information about custom transformations, see:
https://jestjs.io/docs/code-transformation
3a7a025
to
c021555
Compare
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Not sure why these packages are named. They haven't been changed in the this PR. At least they do not shpw up as changed in the lock-file diff or am I missing something? |
Describe the changes you have made in this PR
Removes the citadel npm package
Link this PR to an issue [optional]
Step 2: #1314
Type of change
(Remove other not matching type)
chore
Checklist