Push buttons to bottom in Send and Receive Screens #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name) Don't forget: keep earning sats! |
escapedcat
reviewed
Oct 26, 2022
added 2 commits
October 26, 2022 17:52
Also fixes green background issue #1650
im-adithya
force-pushed
the
task-send-receive
branch
from
5d40236 to
ac7553f
Compare
bumi
reviewed
Oct 27, 2022
| @@ -191,7 +191,7 @@ function Receive() { | |||
| } | |||
|
|
|||
| return ( | |||
| <div> | |||
| <div className="h-full flex flex-col overflow-y-auto no-scrollbar"> | |||
There was a problem hiding this comment.
are we save to not want scrollbars?
There was a problem hiding this comment.
We decided against scrollbars a long time ago. We already do this on most screens.
If we want to change this we should do it in a new issue. Or is this blocking?
There was a problem hiding this comment.
I think we're currently trying to fit everything into the extension-screen without scrollbars:
#1662
bumi
added a commit
that referenced
this pull request
Nov 1, 2022
…nnector # By Lisa Oppermann (15) and others # Via GitHub (22) and others * feature/generic-webln-request: (58 commits) feat: add generic request method to webln fix: publisher link on AllowanceView Translated using Weblate (Italian) Update all development Yarn dependencies (2022-10-29) fix: align reject/close function params fix: navigate on send Update dayjs to version 1.11.6 fix: disable input fields on Create Invoice #1659 (#1668) Update react-i18next to version 12.0.0 Push buttons to bottom in Send and Receive Screens (#1672) refactor(lnurl): getDetails - avoid typecasting (#1545) style: prettier Translated using Weblate (Italian) Update tailwindcss to version 3.2.1 style: prettier Translated using Weblate (Portuguese (Brazil)) style: prettier Translated using Weblate (Italian) Translated using Weblate (Swedish) fix: remove response and additional error message ... # Conflicts: # yarn.lock
bumi
added a commit
that referenced
this pull request
Nov 1, 2022
# By Lisa Oppermann (15) and others # Via GitHub (22) and others * master: (57 commits) fix: publisher link on AllowanceView Translated using Weblate (Italian) Update all development Yarn dependencies (2022-10-29) fix: align reject/close function params fix: navigate on send Update dayjs to version 1.11.6 fix: disable input fields on Create Invoice #1659 (#1668) Update react-i18next to version 12.0.0 Push buttons to bottom in Send and Receive Screens (#1672) refactor(lnurl): getDetails - avoid typecasting (#1545) style: prettier Translated using Weblate (Italian) Update tailwindcss to version 3.2.1 style: prettier Translated using Weblate (Portuguese (Brazil)) style: prettier Translated using Weblate (Italian) Translated using Weblate (Swedish) fix: remove response and additional error message fix: use math floor everywhere ... # Conflicts: # yarn.lock
bumi
added a commit
that referenced
this pull request
Nov 5, 2022
# By Lisa Oppermann (15) and others # Via GitHub (35) and escapedcat (1) * master: (75 commits) fix: remove runcitadel sdk dependency (#1681) chore(deps): update puppeteer to v19 revert(deps): puppeteer and fake-indexdb Update fake-indexeddb to version 4.0.0 Update @types/chrome to version 0.0.200 Update puppeteer to version 19.2.0 fix: publisher link on AllowanceView Translated using Weblate (Italian) Update all development Yarn dependencies (2022-10-29) chore: remove showcases chore: remove topup app fix: align reject/close function params fix: navigate on send Update dayjs to version 1.11.6 fix: disable input fields on Create Invoice #1659 (#1668) Update react-i18next to version 12.0.0 Push buttons to bottom in Send and Receive Screens (#1672) refactor(lnurl): getDetails - avoid typecasting (#1545) style: prettier Translated using Weblate (Italian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Title
Link this PR to an issue [optional]
Fixes #1671
Fixes #1670
Fixes #1650
Type of change
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
How has this been tested?
Manually
Checklist