fix(connectors): lnbits incoming payments shows outgoing ones as well

[escapedcat]

Describe the changes you have made in this PR

lnbits payments api shows outgoing and incoming payments. Negative ones are outgoing and need to be filtered out for our incoming txs.

Link this PR to an issue [optional]

Fixes #1631

Type of change

• fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

How has this been tested?

Manually by sendign sats back and forth

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

---

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

[bumi]

did you test it (potentially with different lnbits installations)?
is the ordering correct (maybe also add the sorting there?)?

[escapedcat]

did you test it (potentially with different lnbits installations)?

Isn't the API behaving the same among lnbits installations? Where else could I test it?

is the ordering correct (maybe also add the sorting there?)?

Sorting looks good, no? See screenshot above.

[bumi]

if you tested it and everything works, then merge it.
I'd still add the sorting (which you added also for lnd)?

[escapedcat]

if you tested it and everything works, then merge it.

Tested with our lnbits account form the e2e tests.

I'd still add the sorting (which you added also for lnd)?

The sort takes care of an API flaw which doesn't exist in the lnbits API. So I would not add it.