fix(connectors): lndhub incoming tx order #1625

[escapedcat]

Describe the changes you have made in this PR

Add reverse to incoming payments to correct wrong order

Link this PR to an issue [optional]

Fixes #1625

Type of change

• fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually with a bluewallet account

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

---

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

[bumi]

I actually think that this breaks other lndhub implementations like the Alby accounts.
those return the invoices in the useful order. Did you test that?

instead of doing the reverse it should be probably ordered by settleDate.

[escapedcat]

Thanks, yes! Fixed it. Also switched it for LND.

[bumi]

lnd is at least reliable, because it is specifically that LND. and they have an parameter that we use there for the sorting.

[escapedcat]

lnd is at least reliable, because it is specifically that LND. and they have an parameter that we use there for the sorting.

Yeah but I think that's just for the "whole" list in terms of "last page". We still need to "reverse" that last page. afaik that's why we added the reverse there in the first place.