-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(home): extract AllowanceView and DefaultView #1613
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by:
Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name) Don't forget: keep earning sats! |
59a7b3c
to
e7459a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
---package-lock.json must not be in the repo. we use yarn.---
github navigation fu*up sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change we no longer show the tipping option if we have an allowance.
The "send satoshi" option will only be available for sites without allowance.
Once a user clicks on a lightning:
link on a page there will be an allowances saved.
So I think this restriction is too much?
@reneaaron what have been thoughts and cases here?
0c78572
to
9965cce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code and tested the extension.
@bumi I can't really imagine the effects of our scripts using WebLN inpage (like with the Youtube buttons). But let's take care of that as we get there.
Yes, we'll see. then it should be pure inpage webln and the page will have an allowance. |
@bumi Please approve this PR, otherwise I can not merge because of the "requested changes" |
Looks like we're good here. I'll merge once this is 💚 |
Describe the changes you have made in this PR
This is a bigger refactoring which divides the Home screen (initial screen in PopUp) into two views:
The refactoring required these steps:
payments
for the componentTransactionTable
are createdTransaction
type withpublisherLink
as this is the main difference between the TransactionTable data in views for Allowance, Default (no Allowance), PublisherSingleViewscreens/Home/DefaultView
andscreens/Home/AllowanceView
⭐ PLEASE follow the commit history if you have problems reading the diff ⭐
Link this PR to an issue [optional]
Closes #1359
Closes #1356
Type of change
feat
: New feature (non-breaking change which adds functionality)How has this been tested?
keysend
(<meta name="lightning" content="method=keysend; address=030a58b8653d32b99200a2334cfe913e51dc7d155aa0116c176657a4f1722677a3; customKey=696969; customValue=3wQCCrfOAMYNzOh1sL05" />
)Would be cool to have a list of sites/pages to test in general.
And I can add more tests to this PR too of course.
Checklist