Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text displayed with tags #1597 #1604

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

vaibhavgarg237
Copy link
Contributor

@vaibhavgarg237 vaibhavgarg237 commented Oct 10, 2022

Describe the changes you have made in this PR

_LNURL_Auth's hint text in the settings tab is displayed with HTML tags. They need to be parsed so that hint text is shown as expected with relevant break and strong tags

Link this PR to an issue [optional]

Fixes #1597

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

#Updated Image
image

#Old Image
image

How has this been tested?

✅ Unit tests

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@vaibhavgarg237 vaibhavgarg237 marked this pull request as ready for review October 10, 2022 18:22
@github-actions
Copy link

github-actions bot commented Oct 10, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

@escapedcat
Copy link
Contributor

escapedcat commented Oct 11, 2022

No need to introduce a new package here.

The strong-tag should be handled like this:

The brs can be removed. I don't think we reallyt need those in the hint-texts. If we would we could use something like this maybe: https://stackoverflow.com/a/54747308/1667461
But for now we're good without.

@vaibhavgarg237
Copy link
Contributor Author

vaibhavgarg237 commented Oct 11, 2022

@escapedcat I have updated the commit with the required changes.

Updated Image

image

Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@escapedcat escapedcat merged commit f657162 into getAlby:master Oct 12, 2022
@vaibhavgarg237 vaibhavgarg237 deleted the removeTags branch October 12, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants