feat: add linters #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create rules for prettier according to the files in codebase add husky pre commit hook signed-off-by: pavan joshi <[email protected]>
change lint-staged rules for prettier signed-off-by: pavan joshi <[email protected]>
pavanjoshi914
force-pushed
the
add-linting
branch
from
69ffe70
to
07e0ffc
Compare
rolznz
reviewed
Aug 14, 2023
|
@pavanjoshi914 the changes look good to me. But surely there will be more file changes after we actually run those commands (for example, running prettier)? did the commit checks pass for you? Can you merge master into this branch and check if the CI passes, and make sure the CI runs the correct checks? |
pavanjoshi914
force-pushed
the
add-linting
branch
from
330cf30
to
04c1822
Compare
|
@pavanjoshi914 please also add a new PR off of this branch and run the linting so we can see the changes |
rolznz
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add prettier
add husky to create pre commit hooks
add lint-staged pre commit hook for prettier
move jsx file to examples folder
add eslint
add eslint typescript parser
add config plugin to run eslint and prettier serially
Fixes #43
signed-off-by: pavan joshi [email protected]