Skip to content

Conversation

@guptamukund22
Copy link

  • Refactored API client to introduce modular HTTP handlers (httpGet, httpPost, httpDelete) for improved code readability, maintainability, and reduced redundancy across API endpoint methods.

@rolznz rolznz requested a review from pavanjoshi914 April 1, 2025 09:56
@pavanjoshi914
Copy link
Contributor

most of the changes look irrelevant here. https://github.com/getAlby/js-sdk/blob/master/.vscode/settings.json we use prettier for formatting and enforce traillingComma rule on code formats. and i guess you just removed at most of the place. can you update this pr to undo this?

@guptamukund22
Copy link
Author

I have fixed the formatting issues using prettier. Please let me know if any other changes are needed.

@rolznz
Copy link
Contributor

rolznz commented Apr 14, 2025

Hi @guptamukund22 could you fix the conflict? and @pavanjoshi914 could you do a more thorough review?

@rolznz rolznz marked this pull request as draft May 29, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants