fix(docker_retry): use /usr/bin/true for macOS portability - #28
Merged
Conversation
Three retry-loop tests pass /bin/true as the runtime path to invoke a real subprocess that succeeds without a Docker daemon. /bin/true is absent on the macOS GitHub Actions runner images, so these tests have been failing on the Test (MVP fast) (macos) job for some time. /usr/bin/true exists on both Linux (Ubuntu) and macOS. Switching to it fixes the failure with no semantic change to what the tests assert. Tests: - run_build_succeeds_on_first_attempt_without_hook - run_build_recovers_after_transient_failures - run_build_gives_up_after_exhausting_retries Surfaced while reviewing CI on the MSRV/cargo-deny PR (#26). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pofallon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three retry-loop tests in `crates/core/src/docker_retry.rs` pass `/bin/true` as a stand-in runtime path to invoke a real subprocess that succeeds without a Docker daemon. `/bin/true` is absent on the macOS GitHub Actions runner images, so these tests have been failing on the `Test (MVP fast) (macos)` job since they were added.
`/usr/bin/true` exists on both Linux (Ubuntu CI) and macOS GHA runners (verified locally on Linux: `ls -la /bin/true /usr/bin/true`). Switching fixes the failure with no semantic change to the tests.
Affected tests
Test plan
Context
Surfaced while reviewing CI on #26 (MSRV bump + cargo-deny). Once this lands, #26 and #27 can be rerun and macOS will go green.
🤖 Generated with Claude Code