[bugfix] Fix error when running with submodules #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in get-woke/go-git#1 which adds including .git/info/exclude automatically
… handled by the go-get library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
.git/info/excludeis explicitly listed as an "gitignore" file when building the list of patterns that will be ignored when running woke. It's causing issues when using submodules, since the ignorer library woke uses will recursively search for these ignore files, but submodules.gitis actually a link and causes woke to fail.What is the new behavior (if this is a feature change)?
In a newer version of the go-git library that woke uses to compile the ignore patterns, parsing
.git/info/excludeis handled by default and is not needed explicitly within woke anymore.Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information:
Fixes #192