-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to pull in rules from remote repos #122
Ability to pull in rules from remote repos #122
Conversation
…alidURL (stylecheck)
…alidURL (stylecheck)
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 95.90% 95.27% -0.64%
==========================================
Files 21 22 +1
Lines 708 740 +32
==========================================
+ Hits 679 705 +26
- Misses 18 21 +3
- Partials 11 14 +3
Continue to review full report at Codecov.
|
…all to a yaml file
I am merging in some updates which should resolve most of your above comments:
I would suggest an add on feature which allows you to set multiple remote configs, as I noticed that setting multiple local configs is not supported yet either. Open to more feedback on this round of updates :) |
I know there was a GitHub actions outage earlier today, which is probably why the PR checks didnt run. They should run the next time you push but I'll be on the lookout. I'm hoping the codecov report is just out of date, but it looks like there's a dip in the coverage of |
GitHub Action run 1, commit: 7eb51dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also committed the compiled binary woke
, it should be removed.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature & Docs Update w/ feature
What is the current behavior? (You can also link to an open issue here)
This PR adds functionality to pull in remote rules from urls - https.
To test this PR locally:
go build
go run main.go -c "https://raw.githubusercontent.com/get-woke/woke/main/example.yaml" --debug
To test a 404 URL:
go run main.go -c "https://raw.githubusercontent.com/get-woke/woke/main/example" --debug
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
Other information: