Fix: Added try/catch error handling to delete action button #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a try/catch block to the delete note functionality so as to prevent any potential runtime failures to delete.
Collaborator
ianmacartney
left a comment
ianmacartney
left a comment
There was a problem hiding this comment.
I believe the user will not get any feedback that something went wrong in this case - a toast would be a good improvement - here only a developer would learn more. wdyt?
Author
|
Yes, I believe so that would enhance this from a user perspective surely.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete note fucntionality was missing error handling on client side. So I wrapped the delete action function inside a try/catch block for better error handling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.