Skip to content

fix coverage folder for Qodana #35

fix coverage folder for Qodana

fix coverage folder for Qodana #35

GitHub Actions / Qodana for JVM completed Aug 16, 2023 in 0s

39 new problems found by Qodana for JVM

Qodana for JVM

39 new problems were found

Inspection name Severity Problems
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 5
Default annotation parameter value 🔶 Warning 4
Unchecked warning 🔶 Warning 4
Statement with empty body 🔶 Warning 3
@NotNull/@Nullable problems 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 2
Field may be 'final' 🔶 Warning 2
Result of method call ignored 🔶 Warning 2
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 2
Unresolved view reference 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Declaration has problems in Javadoc references 🔶 Warning 1
'Collection.toArray()' call style 🔶 Warning 1
Redundant 'if' statement 🔶 Warning 1
Unnecessary semicolon 🔶 Warning 1
Unused assignment 🔶 Warning 1
Vulnerable declared dependency 🔶 Warning 1
Duplicated code fragment ◽️ Notice 2
Method can be extracted ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 116 in src/main/java/de/gessnerfl/fakesmtp/smtp/server/Session.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Class is exposed outside of its visibility scope

Class `ServerThread` is exposed outside its defined visibility scope

Check warning on line 29 in src/main/java/de/gessnerfl/fakesmtp/smtp/util/EmailUtils.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Variable is already assigned to this value

Check warning on line 24 in src/main/java/de/gessnerfl/fakesmtp/smtp/util/EmailUtils.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Variable is already assigned to this value

Check warning on line 24 in src/main/java/de/gessnerfl/fakesmtp/model/Email.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Default annotation parameter value

Redundant default parameter value assignment

Check warning on line 13 in src/main/java/de/gessnerfl/fakesmtp/model/query/FilterExpression.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Default annotation parameter value

Redundant default parameter value assignment

Check warning on line 9 in src/main/java/de/gessnerfl/fakesmtp/model/InlineImage.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Default annotation parameter value

Redundant default parameter value assignment

Check warning on line 20 in src/main/java/de/gessnerfl/fakesmtp/model/Email.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Default annotation parameter value

Redundant default parameter value assignment

Check notice on line 80 in webapp/src/pages/email-list-page.spec.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Duplicated code fragment

Duplicated code

Check notice on line 132 in webapp/src/pages/email-list-page.spec.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Duplicated code fragment

Duplicated code

Check warning on line 70 in src/main/java/de/gessnerfl/fakesmtp/smtp/auth/PlainAuthenticationHandlerFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`for` statement has empty body

Check warning on line 47 in src/main/java/de/gessnerfl/fakesmtp/smtp/command/DataCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`while` statement has empty body

Check warning on line 78 in src/main/java/de/gessnerfl/fakesmtp/smtp/auth/PlainAuthenticationHandlerFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`for` statement has empty body

Check notice on line 63 in src/main/java/de/gessnerfl/fakesmtp/smtp/auth/PlainAuthenticationHandlerFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Method can be extracted

It's possible to extract method returning 'firstNul' from a long surrounding method

Check warning on line 19 in src/main/java/de/gessnerfl/fakesmtp/metrics/MetricsMessageListener.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field may be 'final'

Field `blockedRecipientAddresses` may be 'final'

Check warning on line 17 in src/main/java/de/gessnerfl/fakesmtp/metrics/MetricsMessageListener.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field may be 'final'

Field `registry` may be 'final'

Check warning on line 160 in src/main/java/de/gessnerfl/fakesmtp/smtp/server/Session.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Result of method call ignored

Result of `InetAddress.getHostName()` is ignored

Check warning on line 217 in src/main/java/de/gessnerfl/fakesmtp/smtp/server/ServerThread.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Result of method call ignored

Result of `ExecutorService.awaitTermination()` is ignored

Check warning on line 20 in src/main/java/de/gessnerfl/fakesmtp/smtp/io/DotTerminatedOutputStream.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `write()`

Check warning on line 16 in src/main/java/de/gessnerfl/fakesmtp/model/query/SearchSpecification.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NonNullApi parameter

Check warning on line 16 in src/main/java/de/gessnerfl/fakesmtp/model/query/SearchSpecification.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NonNullApi parameter

Check warning on line 16 in src/main/java/de/gessnerfl/fakesmtp/model/query/SearchSpecification.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NonNullApi parameter

Check warning on line 49 in src/main/java/de/gessnerfl/fakesmtp/smtp/command/MailCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

'size() == 0' can be replaced with 'isEmpty()'

`ssize.length() > 0` can be replaced with '!ssize.isEmpty()'

Check warning on line 16 in src/main/java/de/gessnerfl/fakesmtp/smtp/util/EmailUtils.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

'size() == 0' can be replaced with 'isEmpty()'

`address.length() == 0` can be replaced with 'address.isEmpty()'

Check warning on line 20 in src/main/java/de/gessnerfl/fakesmtp/controller/UiRouteController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Unresolved view reference

Cannot resolve MVC view 'index'

Check warning on line 15 in src/main/java/de/gessnerfl/fakesmtp/controller/UiRouteController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Unresolved view reference

Cannot resolve MVC view 'index'