Ol5 upgrade #77
Merged
Ol5 upgrade #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahennr
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Nice work @annarieger
IMHO, we should release a final version running with ol4 before merging. After that, we should start with version 1.0.0, shouldn't we? @terrestris/devs
annarieger
force-pushed
the
ol5-upgrade
branch
from
04caf5c to
b56e721
Compare
|
Thanks for review @ahennr 🍍 I'm done with last ol4 based release (s. https://github.com/terrestris/geostyler-openlayers-parser/releases/tag/v0.21.0), so I'm going to merge this one as well.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
This PR can be considered as basic preparation for the future transition to the
ol5. Changes are expected after TypeScript definitions for theol5release are published (s. also openlayers/openlayers#8120)Notes:
Due to this upgrade your parent package/application won't work with
olversion older than 5.x To restore the functionality please refer to the official upgrade guide.A
index.d.tsfile containing currently missing ol5 type declarations is added. After@types/ol5is done this file is very probably to be removed again as obsolete.Currently all
olrelated types were replaced by very commonanytype (s.865fd55) - this commit is very likely to be reverted after
types/ol5is avaliable.Please kindly review @KaiVolland @dnlkoch