-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to log4j2 #316
Update to log4j2 #316
Conversation
5a3259b
to
f2f9ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes look pretty obvious to me. That said, I have no experience with GeoStore, so I can't say if there is anything else that needed to be modified.
@@ -27,7 +27,8 @@ | |||
*/ | |||
package it.geosolutions.geostore.services.rest.auditing; | |||
|
|||
import org.apache.log4j.Logger; | |||
import org.apache.logging.log4j.LogManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import does not really seem to be in use (mass update/replace I presume)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -694,6 +704,12 @@ | |||
<groupId>org.acegisecurity</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acegi? Ouch this is pretty darn old. How does it work if you remove log4j classic? Is it going through a logger facade library? Did you provide the right binding jars for it? (it's so old it might be using commons-logging)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acegi is need for jasypt 1.8 whom encoder implements its interface. Removing that jar is not a straight forward thing since it is required to modifies the geostore password encoder: jasypt 1.9 seems to be not backward compatible
659e346
to
afe8611
Compare
This shows the geostore logs at debug level on console appender:
The following is from a log file when using file appender (with mapstore):