Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keycloak support #282

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Add keycloak support #282

merged 2 commits into from
Jun 17, 2022

Conversation

taba90
Copy link
Contributor

@taba90 taba90 commented Jun 13, 2022 •
edited
Loading

This pr:

  • rename some class and does some refactoring to make room for the keycloak support
  • add keycloak support uniformizing login, logout and refresh operation to the REST api already in place for OpenId.

@taba90 taba90 requested a review from offtherailz June 13, 2022 12:15
@taba90
Copy link
Contributor Author

taba90 commented Jun 13, 2022 •
edited
Loading

jdk11 setup fails, it seems unrelated to the code changes. @offtherailz do you have any hint about it?

UPDATE
it was an issue from github itself. Seems that they have solved it

@ale-cristofori ale-cristofori mentioned this pull request Jun 14, 2022
Closed
4 tasks
offtherailz
offtherailz reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't tested this time, because I don't think it can damage MapStore application inserlf and I can wait to configure it in MapStore.

  • Remove changes to geostore.properties

@taba90 taba90 merged commit c2dad83 into geosolutions-it:master Jun 17, 2022
This was referenced Jun 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taba90 @offtherailz