Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corporate proxy issue prevents connections between MS and GN #250

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Corporate proxy issue prevents connections between MS and GN #250

merged 1 commit into from
Jan 27, 2022

Conversation

shad-git
Copy link

@shad-git shad-git commented Jan 25, 2022 •
edited
Loading

Updates the HTTP client to 4.5.13.

@tdipisa tdipisa requested a review from offtherailz January 25, 2022 08:25
@tdipisa tdipisa added this to the 2022.01.00 milestone Jan 25, 2022
@tdipisa
Copy link
Member

tdipisa commented Jan 25, 2022 •
edited
Loading

Thank you so much @shadab-geo. @offtherailz can you please spend some time reviewing this? @nmco it would be good, in my opinion, if you also can do the same to give your approval.

offtherailz
offtherailz approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tdipisa tdipisa requested a review from nmco January 27, 2022 11:37
@shad-git shad-git changed the title Upgrade httpclient Corporate proxy issue prevents connections between MS and GN Jan 27, 2022
This was referenced Jan 27, 2022
Merged
Merged
@nmco nmco merged commit 3b40c87 into geosolutions-it:master Jan 27, 2022
@MV88
Copy link
Contributor

MV88 commented Feb 3, 2022

@tdipisa @offtherailz

FYI
this change broke the build on mapstore c039 project
because it was not specifying the version of
commons-httpclient

@nmco
Copy link
Collaborator

nmco commented Feb 3, 2022

What do you mean @MV88? What version is missing?

@MV88
Copy link
Contributor

MV88 commented Feb 3, 2022

@nmco see here https://github.com/geosolutions-it/MapStore2-C039/pull/220

as far as i understood
it was missing in the pom on the related project
and it was using the wrong one

@MV88
Copy link
Contributor

MV88 commented Feb 3, 2022

@nmco

Me @dromagnoli and @tdipisa have discussed about this as we are taking care of
no need for you to do anything about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

@nmco nmco Awaiting requested review from nmco

Assignees

@shad-git shad-git

Labels
C027-COMUNE_FI-2021-SUPPORT enhancement
Projects
None yet
Milestone
2022.01.00
Development

Successfully merging this pull request may close these issues.
6 participants
@shad-git @tdipisa @MV88 @nmco @offtherailz @shadabgada