-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade of Spring dependency to a more recent version #233
Conversation
@mbarto can you please merge with master, so you can run the actions for unit tests. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So we was actually synchronizing master with 1.8-SNAPSHOT with this PR geosolutions-it/MapStore2#7251
. Before merging we should update log4j too?
Not needed |
So I didn't understood this point. |
as clarified with @mbarto I'm going to close my PR geosolutions-it/MapStore2#7251 in favor on #7172 |
Connected to #232
The purpose of this work is to upgrade the Spring dependency to a more recent version, to enable implementing features that depend on Spring libraries that are not compatible with the actual 3.0.5 version.
Upgrading Spring required upgrading other libraries that depend on it. A short list:
After upgrading the libraries, all tests have been run (both offline and online) and passing. Some manual testing has been done too, including tests with MapStore.
Most of the changes in code are for:
BREAKING CHANGES: