Allow to remove header group prefix #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
reviewed
Jun 16, 2020
| @@ -77,6 +81,9 @@ protected void authenticate(HttpServletRequest req) { | |||
| if (groupName.equals(GroupReservedNames.EVERYONE.groupName())) { | |||
| everyoneFound = true; | |||
| } | |||
| if(groupHeaderPrefix != null && groupName.startsWith(groupHeaderPrefix)) { | |||
There was a problem hiding this comment.
It would be useful to implement a more generic (and optional) groupName mapper that transforms group names using an SpEl expression.
There was a problem hiding this comment.
I thought about it, I didn't do that because testing was hard. Now I'm more confident and I think I can do it relatively quickly
I need a map of regex --> expression.
| @@ -77,6 +81,9 @@ protected void authenticate(HttpServletRequest req) { | |||
| if (groupName.equals(GroupReservedNames.EVERYONE.groupName())) { | |||
| everyoneFound = true; | |||
| } | |||
| if(groupHeaderPrefix != null && groupName.startsWith(groupHeaderPrefix)) { | |||
| groupName = groupName.replaceAll(groupHeaderPrefix, ""); | |||
There was a problem hiding this comment.
I think this is going to transform ROLE_SOMETHINGROLE_ into SOMETHING, because of replaceAll
mbarto
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to remove from role headers a prefix for mapping groups.