Nested groups support for LDAP based authentication #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntication, updated version to 1.4.3-SNAPSHOT
ghost
assigned 
fernandor777
reviewed
May 3, 2019
| for (Object authority : ldapAuthorities) { | ||
| Authority ldapAuthority = (Authority)authority; | ||
| addAuthority(authorities, authorityPrefix, ldapAuthority.getName()); | ||
| if (hierarchical && level < maxLevelGroupsSearch) { |
There was a problem hiding this comment.
As probable improvement, here could we check also if current ldap group isn't already on Set authorities, for avoiding possible Ldap (bad?) circular references and long recursive calls?
Asking this since I'm checking it on GS side.
There was a problem hiding this comment.
Yes, that's absolutely possible. I will add this additional check. thanks
… authorities populator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.