Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#175: Increase groupname size #177

Merged
merged 2 commits into from
May 4, 2018
Merged

#175: Increase groupname size #177

merged 2 commits into from
May 4, 2018

Conversation

tdipisa
Copy link
Member

@tdipisa tdipisa commented Apr 6, 2018

Fix #175

@ghost ghost assigned tdipisa Apr 6, 2018
@ghost ghost added the review label Apr 6, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 32.183% when pulling 4e5e6d6 on tdipisa:issue_175 into efef5b8 on geosolutions-it:master.

@coveralls
Copy link

coveralls commented Apr 6, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 32.052% when pulling ba06e9c on tdipisa:issue_175 into efef5b8 on geosolutions-it:master.

@tdipisa tdipisa requested a review from etj April 6, 2018 10:14
@Gnafu
Copy link
Contributor

Gnafu commented Apr 6, 2018

I'm curious, why 100 ? why not 256? or 1000?

@tdipisa tdipisa requested a review from mbarto April 9, 2018 10:30
mbarto
mbarto suggested changes Apr 9, 2018
View reviewed changes
src/core/model/src/test/java/it/geosolutions/geostore/core/model/UserGroupTest.java Outdated
String s = MARSHALER.marshal(g0);
UserGroup ug = MARSHALER.unmarshal(s);

System.out.println(g0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this ones

src/core/model/src/main/java/it/geosolutions/geostore/core/model/UserGroup.java Outdated
@@ -68,7 +68,7 @@
@GeneratedValue
private Long id;

@Column(nullable = false, updatable = false, length = 20)
@Column(nullable = false, updatable = false, length = 100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groupname in sql scripts is 255 in length, we should use the same number here

@tdipisa tdipisa removed the request for review from etj April 27, 2018 15:15
@tdipisa tdipisa merged commit d4b6dff into geosolutions-it:master May 4, 2018
@ghost ghost removed the review label May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto approved these changes

Assignees

@tdipisa tdipisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdipisa @coveralls @Gnafu @mbarto