Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed StandardContainer rendering in Ms2 jsapi #4465

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

kappu72
Copy link
Contributor

@kappu72 kappu72 commented Nov 8, 2019

Description

With Chrome (78.0.3904.87) Ms2-geonode integration has become unsable,
on any state change all the app is rerndered starting from the StandardContainer.
This pull fixes the function that connect the to the component.
Has to be backported in 2019.02.xx

Issues

Please check if the PR fulfills these #4455 rements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Continuos rerendering of standarcontainer

What is the new behavior?
Fixed

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 84.512% when pulling 48e9df9 on kappu72:issue#4455 into a244fb9 on geosolutions-it:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants