Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Close #691 #693

Merged
merged 5 commits into from
Jul 8, 2015
Merged

Close #691 #693

merged 5 commits into from
Jul 8, 2015

Conversation

kappu72
Copy link
Contributor

@kappu72 kappu72 commented Jul 1, 2015

To add cookies consent, just pass in configuration file
"cookieConsent":{"link":true}.
If you like to skip link, use "cookieConsent":true or "cookieConsent":{"link":false}.
To customize consent cookies text and link, change default values in mapmanager and geoexplorer translation files.
System is based on https://www.cookiechoices.org/ library.

@tdipisa
Copy link
Member

tdipisa commented Jul 2, 2015

Below some considerations:

  • Why "cookieConsent":{"link":true} and not simply "cookieConsent": true?
  • In the cookiechoices.js file I think you have to specify any modifications introduced, as indicated by the Apache license
  • In accordance with Law Decree we have to provide an explanation about cookies we use. I think you can add an additional HTML page containing all mandatory informations.
  • By default the info link should be point to the newly provided html section.

@kappu72
Copy link
Contributor Author

kappu72 commented Jul 7, 2015

Changed configuration from "cookieConsent":{"link":true} to "cookieConsent": true.
Added English Italian explanation page about cookies we use.

@tdipisa
Copy link
Member

tdipisa commented Jul 8, 2015

Hi Kappu,

your changes are ok, you have just to fix the paragraph titles in the english explanation text.

@kappu72
Copy link
Contributor Author

kappu72 commented Jul 8, 2015

Sorry about this, fixed.

tdipisa pushed a commit that referenced this pull request Jul 8, 2015
@tdipisa tdipisa merged commit 959a940 into geosolutions-it:master Jul 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants