Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Use Widgets instead plugins for new SpatialSelectorQuery form #339

Closed
tdipisa opened this issue Mar 6, 2014 · 1 comment · Fixed by #354
Closed

Use Widgets instead plugins for new SpatialSelectorQuery form #339

tdipisa opened this issue Mar 6, 2014 · 1 comment · Fixed by #354
Assignees
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Mar 6, 2014

About the pull request below:
#333

Plugins are used in order to implement specific selection methods.

In MapStore a Plugin must provide a complete functionality, available in the Viewer when his configuration is enabled. This isn't the case of the current XXXSelectionMethod plugins.
These cases, which include specific operations, require the use of widgets. Widgets can be used by a certain plugin in order to provide full functionality (the mapstore's Tool).
Then the plugin configuration could contain the widgets's configuration to use.
This behavior make the widgets more reusable for all mapstore tools, a widgets isn't a plugin.

@tdipisa tdipisa added this to the 1.6 milestone Mar 6, 2014
@tdipisa tdipisa added task and removed duplicate labels Mar 6, 2014
@alediator alediator self-assigned this Mar 6, 2014
alediator added a commit to alediator/mapstore that referenced this issue Mar 6, 2014
Refactor code of the spatial selector methods as widgets instead plugins to fix geosolutions-it#339 issue.
@alediator
Copy link
Contributor

Please review the new code. This branch refactor also the custom geocoder for #335 issue.

If it's ok, I need to change also:

  • Wiki pages
  • Configuration examples

alediator added a commit to alediator/mapstore that referenced this issue Mar 14, 2014
* Export button fixes.
 * Review retrocompatibility for show CSV
 * Allow file export for complex filters
 * New option `exportDoubleCheck`: Flag to make check before export
 * Fixes IE 8 bug on feature grid plugin (on export action)
 * Fix feature grid layout for IE
 * Select `CSV` as default export for the export window.
* Refactor spatial selectors methods
 * Refactor code of the spatial selector methods as widgets instead plugins to fix geosolutions-it#339 issue.
 * Optionally add a geometry operation combo for the spatial filter
alediator added a commit to alediator/mapstore that referenced this issue Mar 14, 2014
* Export button fixes.
 * Review retrocompatibility for show CSV
 * Allow file export for complex filters
 * New option `exportDoubleCheck`: Flag to make check before export
 * Fixes IE 8 bug on feature grid plugin (on export action)
 * Fix feature grid layout for IE
 * Select `CSV` as default export for the export window.
* Refactor spatial selectors methods
 * Refactor code of the spatial selector methods as widgets instead plugins to fix geosolutions-it#339 issue.
 * Optionally add a geometry operation combo for the spatial filter

This commit is related to those issues:

* fixes geosolutions-it#335
* fixes geosolutions-it#339
* fixes geosolutions-it#345
* fixes geosolutions-it#346

Also, I've done some changes on wiki pages in order to harmonize with this code:

* [Gecoder plugin](https://github.com/geosolutions-it/MapStore/wiki/Custom-Geocoder-based-on-WFS)
* [Spatial selector query form plugin](https://github.com/geosolutions-it/MapStore/wiki/SpatialSelectorQueryForm-Plugin)
* [Feature Grid plugin](https://github.com/geosolutions-it/MapStore/wiki/Feature-Grid-Plugin)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants