Fix race condition in tests using the same temporary data directories #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groldan
added
build
groldan
force-pushed
the
fix_temporary_datadir_tests
branch
2 times, most recently
from
de46ecf to
b570750
Compare
Replace hardcoded temporary data directories in test application.yml/bootstrap.yml files by dynamic property sources to avoid unwanted dependencies from tests on the temporary directory existing, or parallel tests stepping on each other.
groldan
force-pushed
the
fix_temporary_datadir_tests
branch
from
b570750 to
924d45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded temporary data directories in test application.yml/bootstrap.yml files by dynamic property sources to avoid unwanted dependencies from tests on the temporary directory existing, or parallel tests stepping on each other.