Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions used in the GCPy environment; Also update GitHub actions to avoid deprecation warnings #329

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jun 5, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This is the companion PR to issues #326 and #328. These issues reported that GCPy installation from the Python Package Index (PyPi) failed due to the xesmf==0.5.1 package having been de-listed. We have made the following updates:

  1. Updated the docs/environment_files/gcpy_environment.yml and docs/environment_files/gcpy_requirements.txt to use the following package versions:
  • python==3.12.0
  • xesmf==0.8.5
  • esmf==8.6.1
  • esmpy==8.6.1
  • with corresponding dependencies solved by Mamba.
  1. Updated the docs/environment_files/read_the_docs_requirements.yml and docs/environment_files/read_the_docs_requirements.txt to use the following package versions:
  • jinja2==3.1.4, this fixes a security issue raised by Dependabot
  1. Now use more recent GitHub actions to avoid deprecation warnings
  • checkout@v4
  • CodeQL@v3
  • publish-python@v5

Expected changes

This will be a zero-diff update. I have tested the 1-year benchmark scripts using a new Mamba environment with the updated package versions and all plots/tables were generated properly.

Related Github Issue


@yantosca yantosca added topic: User Environment Relating to python and/or conda environment category: Bug Fix Fixes a bug that was previously reported labels Jun 5, 2024
@yantosca yantosca added this to the 1.5.1 milestone Jun 5, 2024
@yantosca yantosca requested a review from msulprizio June 5, 2024 22:00
@yantosca yantosca self-assigned this Jun 5, 2024
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

Copy link
Contributor Author

Thanks @msulprizio. I need to do more testing on this to make sure the benchmark outputs are OK with the updated libraries.

GitHub is deprecating Node16.js and recommends updating to Node20.js,
which requires updates of the following GitHub actions:

- CodeQL
- checkout
- stale
- publish-python

Signed-off-by: Bob Yantosca <[email protected]>
docs/environment_files/gcpy_environment.yml
docs/environment_files/gcpy_requirements.yml
- Updated Python to 3.1.0
- Updated esmf and esmpy to 8.6.1
- Updated xesmf to 0.8.5
- Other package dependencies were computed accordingly by Mamba

docs/environment_files/read_the_docs_environment.yml
docs/environment_files/read_the_docs_requirements.txt
- Updated jinja2 to 3.1.4 (fixes a security issue)

setup.py
- Updated the package version numbers accordingly

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor Author

@msulprizio @lizziel: Here are some samples from GCC vs GCHP benchmark output. The GCHP vs. GCC comparisons show a lot of striping but this was present with the existing environment. Also, in the ship emissions, the there are an excessive number of tickmarks... but this is also present in plots generated from the existing environment. Maybe something to think about too.

o3_zonal_gcc_gchp
emis_co_ship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: User Environment Relating to python and/or conda environment
Projects
None yet
2 participants