fix: Remove trait wrappers to work around Rust 1.90 compiler regression#77
Merged
kylebarron merged 8 commits intomainfrom Sep 25, 2025
Merged
fix: Remove trait wrappers to work around Rust 1.90 compiler regression#77kylebarron merged 8 commits intomainfrom
kylebarron merged 8 commits intomainfrom
Conversation
Member
Author
|
I liked the "elegance" of the |
Kontinuation
added a commit
to wherobots/geo
that referenced
this pull request
Sep 25, 2025
… Rust compiler bug in 1.90.0 (#11) This patch removes the GAT `GeometryCollectionTypeExt` from `GeometryTraitExt` because it would introduce recursive GATs such as `G::GeometryCollectionTypeExt::GeometryTypeExt::GeometryCollectionTypeExt::...` and easily trigger a Rust compiler bug: rust-lang/rust#128887 and rust-lang/rust#131960. See also geoarrow/geoarrow-rs#1339. Although this could be worked around by not implementing generic functions using trait-based approach and use function-based approach instead, see geoarrow/geoarrow-rs#956 and georust/wkb#77, we are not certain if there will be other issues caused by recursive GATs in the future. So we decided to completely get rid of recursive GATs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Rust 1.90 caused a regression in release mode for consumers of the
geoarrow-arraycrate: geoarrow/geoarrow-rs#1339, rust-lang/rust#131960. This code compiled fine in 1.89 but no longer compiles in 1.90 in release mode. (It compiles in debug mode)I tracked this down to the trait wrappers implemented here. If you pull main of
geoarrow-rs(geoarrow/geoarrow-rs@338a08c) and runcargo +1.90 build --release -p geoarrow-arrayyou get a compiler error. If you check out the branch in geoarrow/geoarrow-rs#1341 you no longer get a compiler error.Perhaps we should add some docs to the code to explain why we're not using trait wrappers? Then again, this implementation is so simple that I almost think I should've used this from the start.