-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix processing 8-bit RGB images #31
base: master
Are you sure you want to change the base?
Conversation
Just a heads up, in vidstabdefines.h you fixed the PIXN macro but the same mistake is also in PIXELN right above it. PIXELN is used if floating point is enabled instead of fixed point, but they should probably both be fixed. |
Hi @georgmartius . I updated dependencies on my timelapse project to make it buildable again... And this bug is still reproducible with vid.stab master - it is crashing still. Are you interested for the fix? Should I rebase it or update it somehow? Problem is that I don't remember exact details about the patch :-D |
Hi, Sorry for ignoring your patch at the time. |
Field is sometimes located outside of the frame after transformation. It can cause crash in compareSubImg_thr_sse2 function.
Ok, I just rebased my branch on current upstream master. I tried to build it without last commit. And it crashed....
|
Hi, I am creating tools for building timelapse videos. Now I am trying to create tool that reads JPEG images (by ImageMagic) and stabilize it with vidstab lib. I found some problems with processing RGB (8bit depth) images that ends with SIGSEGV. Read commit messages for more information...