listen() only updates display on value change
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listenstores the controller's previous value and only callsupdateDisplayif the value has changed. Should alleviate #35.Originally I thought that redundant assignments to an HTML input's
valuewere free, and that the bottleneck was each controller making its own animation frame request. It turns out consolidating the loops didn't really have an impact on performance.With this PR,
listenhas negligible performance impact until values actually change: I'm able to add 1000 non-updating (yet listening) controllers in the newexamples/listen-stressdemo without dropping frames (2018 MPB). I'm able to get around 80 continuously updating controllers, but I think this bottleneck is browser-side.