Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag
captureKeys
to GUI's constructor. If this is false, GUI will not callstopPropagation()
on key events that originate from within the GUI. The user must then manage event propagation manually using the following or similar.Writing tests for this was tricky. The browser shim needed to be expanded to simulate event propagation.
Open question: Right now, folders titles are treated differently than Controllers. They never capture key events (mostly because of #69). I'm wondering if we should keep this special treatment, or if the
captureKeys
flag would apply to both Controllers and folder titles in the same way.Note to self: the base for this branch was
title-as-button
. Merge that first.