京都の通り名削除の際に「◯号室」が「◯丁目」と正規化されるケースへの対応 #163
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
京都で建物名に
号
が含まれる場合、通り名削除と丁目・番地・号の正規化がコンフリクトしているのが #157 のケースです。建物名としてよくある
号室
を、丁目・番地・号の正規化パターンから除外するのが最も効率的と考えました。同様のパターンで予期しない建物名により正規化が失敗するケースが今後出現すると思われますが、都度同じように対応することでしばらくはそこまでコードの複雑さを増やさずに改善を続けられると考えています。