Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Run tests with provided bundler, drop sudo: false setting #150

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Nov 11, 2019

Use existing Bundler

To try passing the build in CI, this PR tries to run tests with the provided bundle command, instead of trying to install one. Result: This stops the error condition that some of the CI matrix elements could not start building.

Drop sudo: false Travis directive

In addition: This PR removes the no-longer-used Travis setting sudo: false. See more at the Travis blog.

gemfiles/: Drop test-unit duplicates, pick version of sqlite3

In gemfiles, there as a duplication, now removed.

rails3 gemfile asked for a sqlite3 which was not provided.

@coveralls
Copy link

coveralls commented Nov 11, 2019

Coverage Status

Coverage increased (+39.5%) to 85.556% when pulling eaa93cb on olleolleolle:travis-bundler-1 into cc5fd43 on geokit:master.

@ryankopf
Copy link
Member

ryankopf commented Feb 7, 2021

Tests locally work when I merge this, so I'll merge this PR now.

@ryankopf ryankopf merged commit d1c2108 into geokit:master Feb 7, 2021
@olleolleolle olleolleolle deleted the travis-bundler-1 branch February 7, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants