Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same approach for tree theme specific css as used for popup #263

Merged
merged 2 commits into from
Apr 10, 2014

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Apr 10, 2014

No description provided.

@marcjansen
Copy link
Member

I think we should have some short note in The API docs that one needs to include a proper stylesheet (according to the current theme) to get the most out of both the tree and the popup.

It would be great if you could add that comment to the relevant classes, @bartvde.

This looks otherwise great to me.

Please merge and please also update the gh-pages branch with your changes.

Thanks!

@bartvde
Copy link
Member Author

bartvde commented Apr 10, 2014

for gh-pages do I simply merge with master? Or what's the process?

@marcjansen
Copy link
Member

No, this wouldn't work, as the src-directory would then be updated as well. These branches are somewhat out of sync.

The latest commits from @weskamm to the gh-pages were simply cherry-picked from master.

I hope this helps.

@marcjansen
Copy link
Member

And btw. I'd love to have a script making the dirty gh-pages / release work easier. Please answer with "PR to come", 😉.

bartvde pushed a commit that referenced this pull request Apr 10, 2014
Same approach for tree theme specific css as used for popup (r=@marcjansen)
@bartvde bartvde merged commit 4ee549f into geoext:master Apr 10, 2014
@bartvde bartvde deleted the cssfixes branch April 10, 2014 08:28
@bartvde
Copy link
Member Author

bartvde commented Apr 10, 2014

haha :-)

@bartvde
Copy link
Member Author

bartvde commented Apr 10, 2014

I just updated gh-pages let's hope I did not break anything ...

@marcjansen
Copy link
Member

Everything looks fine AFAICT. Thanks Bart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants