Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydra yaml config #81

Merged
merged 30 commits into from
Jun 28, 2024
Merged

Hydra yaml config #81

merged 30 commits into from
Jun 28, 2024

Conversation

kks32
Copy link
Contributor

@kks32 kks32 commented Jun 25, 2024 •
edited
Loading

Use yaml to configure settings rather than command line arguments:

  • Define input file schema and validation
  • Support resume flag
  • Update README
  • move constants to data section

Related Issues/PRs
#80

@kks32 kks32 added the Priority: Medium Priority: Medium label Jun 25, 2024
@kks32 kks32 added this to the GNS v2.0 milestone Jun 25, 2024
@kks32 kks32 requested a review from yjchoi1 June 25, 2024 14:32
@kks32 kks32 self-assigned this Jun 25, 2024
kks32 added 25 commits June 25, 2024 09:27
@kks32
Test CI for config yaml
50c63c2
@kks32
Testing CI for hydra
c93c335
@kks32
Try pip requirements.txt
13c5204
@kks32
Try pip instead of conda for docker
7ebded9
@kks32
Docker build on GitHub
85ff713
@kks32
Copy requirements.txt file before installing on Docker container
e607f98
@kks32
Copy requirements.txt
9913d92
@kks32
Copy requirements.txt
111b428
@kks32
Trying with user flag
3606790
@kks32
Trying Python 3.11
b6cea3e
@kks32
Test CircleCI with ghcr container image
f9cb06d
@kks32
GitHub Actions workflow to test training GNS
5d8ce23
@kks32
Updated dockerfile with paths and env
b230de8
@kks32
Modify workflow to run training
20fa700
@kks32
Add at least one epoch to run when nsteps is fewer than 1 epoch steps
7764f9d
@kks32
Train GNS action
1e612df
@kks32
Test without docker pull on CircleCI
1f0b8cd
@kks32
Specify path and branches
8c0ddad
@kks32
Fix path to GNS sample output
4a7e5c4
@kks32
Worflow runs on Github and remove conda on circleci
c5bcc44
@kks32
No black check
dc27691
@kks32
Only try to build container if specific files have changed
5329b78
@kks32
Fix resume training and README
a97cd5e
@kks32
Reduce number of steps to 100 for testing
170037b
@kks32
Refactor constants to data
40b4919
@kks32 kks32 marked this pull request as ready for review June 25, 2024 23:20
yjchoi1
yjchoi1 reviewed Jun 28, 2024
View reviewed changes
gns/train.py Outdated Show resolved Hide resolved
@yjchoi1
Copy link
Collaborator

yjchoi1 commented Jun 28, 2024 •
edited
Loading

Would it be better to add the configurations from metadata.json to config.yml? However, this might cause compatibility issues with the previous version, which explicitly reads from metadata.json.

Currently, metadata.json controls some of the important hyperparameters like n_message_passing, connectivity_raidus, nnode_in (optional) etc.

Other than these, everything looks good. I tested PR on my actual data for training, rollout, and rendering.

@kks32
Copy link
Contributor Author

kks32 commented Jun 28, 2024

Currently, metadata.json controls some of the important hyperparameters like n_message_passing, connectivity_raidus, nnode_in (optional) etc.

MLP configuration will be part of Configuration file in future PRs. This is planned for v2 to be able to switch between different types of MLPs/KANs

@kks32 kks32 merged commit a28603e into v2 Jun 28, 2024
1 check passed
@kks32 kks32 deleted the config branch June 28, 2024 12:27
@kks32 kks32 mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjchoi1 yjchoi1 yjchoi1 left review comments

Assignees

@kks32 kks32

Labels
Priority: Medium Priority: Medium
Projects
Graph Network Simulator
Status: Done
Milestone
GNS v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kks32 @yjchoi1