Add Dockerfile & automake files #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit to the repository the configure script needed to install the programs.
Open
Throws a notice rather than an error when running configure without Lyx installed.
|
The configure script now only throws a notice rather than an error when it is run without Lyx installed. Because of this change I added the Lyx requirement back, which I mentioned removing in my previous comment. I also removed the demo data from this pull request because it's in the demo-data pull request. |
gassmoeller
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked this branch from anowacki/mineos:config, so it has the automake configure and makefiles needed to actually build the program. I removed the Lyx requirement from the makefile because it seemed to prevent the program from compiling in the ubuntu container. The demo data needed to run the tests is included in another pull request. The docker image is currently located here: https://hub.docker.com/r/jbakerdunn/mineos