Use pressure consistently for viscous creep in visco-plastic #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmyhill
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4247 introduced the option to use adiabatic pressure instead of full pressure to compute viscous creep viscosities in the visco_plastic rheology. However, this was not carried over to the Frank-Kamanetskii option introduced in #5655. This PR makes it consistent, i.e. the same pressure (either adiabatic or full) is used no matter if diffusion / dislocation / Peierls / Frank-Kamanetskii viscosity is computed.
I also removed the list of creep laws from the parameter description to avoid having to update the list whenever we introduce a new creep law.