Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add python script for prefactor scaling #5682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naliboff
Copy link
Contributor

A python script to correctly convert viscous flow prefactor terms from experimental studies such that they are internally consistent with ASPECT's rheological conventions and assumptions.

@bobmyhill @jdannberg @anne-glerum @cedrict - Is this worth adding in, and if yes does the current structure make sense?

FYI, I am going to add a more detailed description of how the scaling works in #5576, but can also do that here as well. For now, I cited the grain size paper, which provides a description of the conventions in an Appendix.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@naliboff naliboff changed the title add python script for prefactor scaling [WIP] add python script for prefactor scaling May 30, 2024
@bobmyhill
Copy link
Member

Hi @naliboff, I think this would be really useful. Would you be willing to make this into a function that people can easily use to scale their own flow law parameters?

@naliboff
Copy link
Contributor Author

Hi @naliboff, I think this would be really useful. Would you be willing to make this into a function that people can easily use to scale their own flow law parameters?

Sure thing, I'll organize this into some type of function for the part that can be generalized. Suggestions for how to handle the unit conversion portions? That is a bit unique to each reported study. Should I keep the current structure as is?

@bobmyhill
Copy link
Member

Would unum be of any use for unit conversions? https://github.com/trzemecki/Unum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants